From 1e235f4e8ec8901a122f80f61dae5d6719ef6b3d Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 21 Jul 2020 19:10:03 +0530 Subject: [PATCH] fix: like in form sidebar --- .../public/js/frappe/form/sidebar/form_sidebar.js | 13 +++++++------ .../js/frappe/form/templates/form_sidebar.html | 6 ++++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/frappe/public/js/frappe/form/sidebar/form_sidebar.js b/frappe/public/js/frappe/form/sidebar/form_sidebar.js index 595c06735e..345a018305 100644 --- a/frappe/public/js/frappe/form/sidebar/form_sidebar.js +++ b/frappe/public/js/frappe/form/sidebar/form_sidebar.js @@ -54,7 +54,7 @@ frappe.ui.form.Sidebar = class { }); this.like_icon.on("click", function() { - frappe.ui.toggle_like(me.like_icon, me.frm.doctype, me.frm.doc.name, function() { + frappe.ui.toggle_like(me.like_wrapper, me.frm.doctype, me.frm.doc.name, function() { me.refresh_like(); }); }); @@ -200,9 +200,9 @@ frappe.ui.form.Sidebar = class { make_like() { this.like_wrapper = this.sidebar.find(".liked-by"); - this.like_icon = this.sidebar.find(".liked-by .octicon-heart"); + this.like_icon = this.sidebar.find(".liked-by .like-icon"); this.like_count = this.sidebar.find(".liked-by .likes-count"); - frappe.ui.setup_like_popover(this.sidebar.find(".liked-by-parent"), ".liked-by"); + frappe.ui.setup_like_popover(this.sidebar.find(".liked-by-parent"), ".like-icon"); } make_follow() { @@ -218,9 +218,10 @@ frappe.ui.form.Sidebar = class { } this.like_wrapper.attr("data-liked-by", this.frm.doc._liked_by); - - this.like_icon.toggleClass("text-extra-muted not-liked", - !frappe.ui.is_liked(this.frm.doc)) + const liked = frappe.ui.is_liked(this.frm.doc); + this.like_wrapper + .toggleClass("not-liked", !liked) + .toggleClass("liked", liked) .attr("data-doctype", this.frm.doctype) .attr("data-name", this.frm.doc.name); diff --git a/frappe/public/js/frappe/form/templates/form_sidebar.html b/frappe/public/js/frappe/form/templates/form_sidebar.html index 81c6dca45e..cb917b3c6f 100644 --- a/frappe/public/js/frappe/form/templates/form_sidebar.html +++ b/frappe/public/js/frappe/form/templates/form_sidebar.html @@ -106,8 +106,10 @@