vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Convert doctype name to string (#19832)

Browse source
This commit is contained in:
Ankush Menat 2023-01-30 14:11:38 +05:30 • committed by GitHub
parent 9f45406fe8
commit 1eab4e4253
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/core/doctype/docshare/test_docshare.py
View file

@ -125,3 +125,17 @@ class TestDocShare(FrappeTestCase):
)
frappe.share.remove(doctype, submittable_doc.name, self.user)
def test_share_int_pk(self):
test_doc = frappe.new_doc("Console Log")
test_doc.insert()
frappe.share.add("Console Log", test_doc.name, self.user)
frappe.set_user(self.user)
self.assertIn(
str(test_doc.name), [str(name) for name in frappe.get_list("Console Log", pluck="name")]
)
test_doc.reload()
self.assertTrue(test_doc.has_permission("read"))

2
frappe/permissions.py
View file

@ -637,7 +637,7 @@ def get_linked_doctypes(dt: str) -> list:
def get_doc_name(doc):
if not doc:
return None
return doc if isinstance(doc, str) else doc.name
return doc if isinstance(doc, str) else str(doc.name)
def allow_everything():