From 1fbd6badd1eecfcf9ba828f9f234e231b60b8ed0 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 23 Feb 2023 15:41:33 +0530 Subject: [PATCH] fix: log full traceback --- frappe/integrations/doctype/webhook/webhook.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/frappe/integrations/doctype/webhook/webhook.py b/frappe/integrations/doctype/webhook/webhook.py index 242468624f..e3740f9d6b 100644 --- a/frappe/integrations/doctype/webhook/webhook.py +++ b/frappe/integrations/doctype/webhook/webhook.py @@ -137,12 +137,10 @@ def enqueue_webhook(doc, webhook) -> None: except Exception as e: frappe.logger().debug({"webhook_error": e, "try": i + 1}) - log_request(doc.doctype, doc.name, webhook.request_url, headers, data, r, e) + log_request(doc.doctype, doc.name, webhook.request_url, headers, data, r) sleep(3 * i + 1) if i != 2: continue - else: - webhook.log_error("Webhook failed") def log_request( @@ -152,7 +150,6 @@ def log_request( headers: dict, data: dict, res: requests.Response | None = None, - error: str | None = None, ): request_log = frappe.get_doc( { @@ -164,7 +161,7 @@ def log_request( "headers": frappe.as_json(headers) if headers else None, "data": frappe.as_json(data) if data else None, "response": frappe.as_json(res.json()) if res else None, - "error": error, + "error": frappe.get_traceback(), } )