fix: codacy

frappe/desk/doctype/event/event.py

@@ -22,12 +22,12 @@ class Event(Document):
 		if not self.starts_on:
 			self.starts_on = now_datetime()
 
-		if self.starts_on and self.ends_on:
-			self.validate_from_to_dates("starts_on", "ends_on")
-
 		# if start == end this scenario doesn't make sense i.e. it starts and ends at the same second!
 		self.ends_on = None if self.starts_on == self.ends_on else self.ends_on
 
+		if self.starts_on and self.ends_on:
+			self.validate_from_to_dates("starts_on", "ends_on")
+
 		if self.repeat_on == "Daily" and getdate(self.starts_on) != getdate(self.ends_on):
 			frappe.throw(_("Daily Events should finish on the Same Day."))
 

frappe/desk/doctype/event/event_list.js

@@ -1,6 +1,6 @@
 frappe.listview_settings['Event'] = {
 	add_fields: ["starts_on", "ends_on"],
-	onload: function(listview) {
+	onload: function() {
 		frappe.route_options = {
 			"status": "Open"
 		};

frappe/patches/v12_0/rename_events_repeat_on.py

@@ -19,9 +19,7 @@ def execute():
 		frappe.db.set_value("Event", daily_event.name, "repeat_on", "Weekly")
 
 	for weekly_event in weekly_events:
-		"""
-			Set WeekDay based on the starts_on so that event can repeat Weekly
-		"""
+		# Set WeekDay based on the starts_on so that event can repeat Weekly
 		frappe.db.set_value("Event", weekly_event.name, "repeat_on", "Weekly")
 		frappe.db.set_value("Event", weekly_event.name, weekdays[get_datetime(weekly_event.starts_on).weekday()], 1)