From 1fe3b5d5bcc88c2d59ad7e3d2d1c3119b487b857 Mon Sep 17 00:00:00 2001 From: Xiaoguang Sun Date: Mon, 1 Jan 2024 14:08:40 +0800 Subject: [PATCH] refactor(workspace): Optimize save call on workspace doc (#24052) Optimize Workspace.save_page to call doc.save() only once therefore eliminate sending unnecessary queries to database. Signed-off-by: Xiaoguang Sun --- frappe/desk/desktop.py | 2 +- frappe/desk/doctype/workspace/workspace.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/frappe/desk/desktop.py b/frappe/desk/desktop.py index a7c9a5ef0c..742bb15176 100644 --- a/frappe/desk/desktop.py +++ b/frappe/desk/desktop.py @@ -565,7 +565,7 @@ def save_new_widget(doc, page, blocks, new_widgets): page, json_config, e ) doc.log_error("Could not save customization", log) - return False + raise return True diff --git a/frappe/desk/doctype/workspace/workspace.py b/frappe/desk/doctype/workspace/workspace.py index 758681b0dc..cd0bb949ca 100644 --- a/frappe/desk/doctype/workspace/workspace.py +++ b/frappe/desk/doctype/workspace/workspace.py @@ -277,7 +277,6 @@ def save_page(title, public, new_widgets, blocks): doc = frappe.get_doc("Workspace", pages[0]) doc.content = blocks - doc.save(ignore_permissions=True) save_new_widget(doc, title, blocks, new_widgets)