From 20178bd3eb158d80a0bcb0bdaa56ba5a5fec9f7c Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Fri, 29 Sep 2023 12:04:38 +0530 Subject: [PATCH] fix: improved validation for address and contact --- frappe/contacts/doctype/address/address.py | 4 +++- frappe/contacts/doctype/contact/contact.py | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/contacts/doctype/address/address.py b/frappe/contacts/doctype/address/address.py index e81a80fb65..ea6e9772fd 100644 --- a/frappe/contacts/doctype/address/address.py +++ b/frappe/contacts/doctype/address/address.py @@ -170,7 +170,9 @@ def get_address_display(address_dict: dict | str | None) -> str | None: return if not isinstance(address_dict, dict): - address_dict = frappe.db.get_value("Address", address_dict, "*", as_dict=True, cache=True) or {} + address = frappe.get_cached_doc("Address", address_dict) + address.check_permission() + address_dict = address.as_dict() name, template = get_address_templates(address_dict) diff --git a/frappe/contacts/doctype/contact/contact.py b/frappe/contacts/doctype/contact/contact.py index e78f1b006c..c1bd2f55ec 100644 --- a/frappe/contacts/doctype/contact/contact.py +++ b/frappe/contacts/doctype/contact/contact.py @@ -217,6 +217,8 @@ def invite_user(contact): @frappe.whitelist() def get_contact_details(contact): contact = frappe.get_doc("Contact", contact) + contact.check_permission() + return { "contact_person": contact.get("name"), "contact_display": contact.get("full_name"),