From b633f31bf4b3e70c71adad71fba5838fbba0d7de Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 15 Dec 2021 18:41:56 +0530 Subject: [PATCH 1/2] fix: set link field to `undefined` instead of empty string This breaks other code where undefined values are removed, technically invalid value for link field => unset link field so it should be undefined --- frappe/public/js/frappe/form/controls/link.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js index 7818e7fd96..d542d4b5be 100644 --- a/frappe/public/js/frappe/form/controls/link.js +++ b/frappe/public/js/frappe/form/controls/link.js @@ -471,7 +471,7 @@ frappe.ui.form.ControlLink = class ControlLink extends frappe.ui.form.ControlDat docname: value, fields: columns_to_fetch, }).then((response) => { - if (!response || !response.name) return ""; + if (!response || !response.name) return undefined; if (!docname || !columns_to_fetch.length) return response.name; for (const [target_field, source_field] of Object.entries(fetch_map)) { From 1e3d58c14f614ecac1eb3e5511a13c7ccae12038 Mon Sep 17 00:00:00 2001 From: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Date: Wed, 15 Dec 2021 21:53:25 +0530 Subject: [PATCH 2/2] refactor: Use null instead of undefined --- frappe/public/js/frappe/form/controls/link.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js index d542d4b5be..95e53394b5 100644 --- a/frappe/public/js/frappe/form/controls/link.js +++ b/frappe/public/js/frappe/form/controls/link.js @@ -471,7 +471,7 @@ frappe.ui.form.ControlLink = class ControlLink extends frappe.ui.form.ControlDat docname: value, fields: columns_to_fetch, }).then((response) => { - if (!response || !response.name) return undefined; + if (!response || !response.name) return null; if (!docname || !columns_to_fetch.length) return response.name; for (const [target_field, source_field] of Object.entries(fetch_map)) {