From 9f51831791b634ef86766fe0251255ebe191fcd5 Mon Sep 17 00:00:00 2001 From: prssanna Date: Fri, 3 Jul 2020 11:09:31 +0530 Subject: [PATCH 1/2] fix: only render header if columns exist --- frappe/public/js/frappe/list/list_view.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index 8da73b0dec..36634c1ff5 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -528,6 +528,10 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } get_header_html() { + if (!this.columns) { + return; + } + const subject_field = this.columns[0].df; let subject_html = ` From 79dfe7e0d47d177afe24411b8e4c4ce6976d32f8 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 7 Jul 2020 19:14:14 +0530 Subject: [PATCH 2/2] fix: render_list in kanban view --- frappe/public/js/frappe/list/list_view.js | 2 +- frappe/public/js/frappe/views/kanban/kanban_view.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index 36634c1ff5..b8239b170a 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -1150,7 +1150,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { }); this.toggle_result_area(); this.render_list(); - if (this.$checks.length) { + if (this.$checks && this.$checks.length) { this.set_rows_as_checked(); } }); diff --git a/frappe/public/js/frappe/views/kanban/kanban_view.js b/frappe/public/js/frappe/views/kanban/kanban_view.js index 4b6792330f..4acde8042c 100644 --- a/frappe/public/js/frappe/views/kanban/kanban_view.js +++ b/frappe/public/js/frappe/views/kanban/kanban_view.js @@ -73,6 +73,10 @@ frappe.views.KanbanView = class KanbanView extends frappe.views.ListView { }); } + render_list() { + + } + on_filter_change() { if (JSON.stringify(this.board.filters_array) !== JSON.stringify(this.filter_area.get())) { this.page.set_indicator(__('Not Saved'), 'orange');