From 2130dd69dec426259ebf8f2a60cba90a3c453998 Mon Sep 17 00:00:00 2001
From: Rushabh Mehta <rmehta@gmail.com>
Date: Mon, 18 Feb 2019 16:37:51 +0530
Subject: [PATCH] fix: add comment in communication

---
 frappe/desk/form/utils.py                     |  3 ++-
 .../public/js/frappe/form/footer/timeline.js  | 20 ++++---------------
 2 files changed, 6 insertions(+), 17 deletions(-)

diff --git a/frappe/desk/form/utils.py b/frappe/desk/form/utils.py
index af0b2c9cec..a0a33f5d42 100644
--- a/frappe/desk/form/utils.py
+++ b/frappe/desk/form/utils.py
@@ -64,7 +64,8 @@ def add_comment(reference_doctype, reference_name, content, comment_email):
 		reference_doctype = reference_doctype,
 		reference_name = reference_name,
 		content = clean_email_html(content),
-		comment_email = comment_email
+		comment_email = comment_email,
+		comment_type = 'Comment'
 	)).insert(ignore_permissions = True)
 
 	return doc.as_dict()
diff --git a/frappe/public/js/frappe/form/footer/timeline.js b/frappe/public/js/frappe/form/footer/timeline.js
index 81359e2ea2..3304c574ee 100644
--- a/frappe/public/js/frappe/form/footer/timeline.js
+++ b/frappe/public/js/frappe/form/footer/timeline.js
@@ -654,22 +654,7 @@ frappe.ui.form.Timeline = class Timeline {
 				if(!r.exc) {
 					me.comment_area.set_value('');
 					frappe.utils.play_sound("click");
-
-					var comment = r.message;
-					var comments = me.get_comments();
-					var comment_exists = false;
-					for (var i=0, l=comments.length; i<l; i++) {
-						if (comments[i].name==comment.name) {
-							comment_exists = true;
-							break;
-						}
-					}
-					if (comment_exists) {
-						return;
-					}
-
-					me.frm.get_docinfo().comments = comments.concat([r.message]);
-					me.refresh(true);
+					frappe.timeline.new_communication(r.message);
 				}
 			}
 		});
@@ -771,6 +756,9 @@ frappe.ui.form.Timeline = class Timeline {
 
 $.extend(frappe.timeline, {
 	new_communication: function(communication) {
+		if (!communication.communication_type) {
+			communication.communication_type = 'Comment';
+		}
 		var docinfo = frappe.model.get_docinfo(communication.reference_doctype, communication.reference_name);
 		if (docinfo && docinfo.communications) {
 			var communications = docinfo.communications;