vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: share doc with everyone (#35634)

Browse source 
* fix: handle shared with everyone case

* chore: remove comment

* fix: remove unrelated change
This commit is contained in:
Kerolles Fathy 2026-01-03 18:05:55 +02:00 • committed by GitHub
parent 59a4764912
commit 21f6fbadba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/public/js/frappe/form/sidebar/share.js
View file

@ -11,7 +11,8 @@ frappe.ui.form.Share = class Share {
}
render_sidebar() {
const shared = this.shared || this.frm.get_docinfo().shared;
const shared_users = shared.filter(Boolean).map((s) => s.user);
const has_everyone = shared.some((s) => s && s.everyone);
const shared_users = shared.filter((s) => s && s.user && !s.everyone).map((s) => s.user);
if (this.frm.is_new()) {
this.parent.find(".share-doc-btn").hide();
@ -26,7 +27,7 @@ frappe.ui.form.Share = class Share {
this.shares.empty();
if (!shared_users.length) {
if (!shared_users.length && !has_everyone) {
this.shares.hide();
return;
}
@ -36,7 +37,12 @@ frappe.ui.form.Share = class Share {
avatar_group.on("click", () => {
this.frm.share_doc();
});
// REDESIGN-TODO: handle "shared with everyone"
if (has_everyone) {
avatar_group.prepend(
frappe.avatar_group(["Everyone"], 1, { align: "left", overlap: true })
);
}
this.shares.append(avatar_group);
}
show() {