vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #32429 from iamejaaz/37368-invalid-file-url

Browse source 
fix: don't allow attaching an file invalid url
This commit is contained in:
Ejaaz Khan 2025-05-13 18:21:41 +05:30 • committed by GitHub
commit 21f79128e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
frappe/public/js/frappe/file_uploader/FileUploader.vue
View file

@ -521,14 +521,37 @@ function upload_via_file_browser() {
library_file_name: selected_file.value,
});
}
function upload_via_web_link() {
async function validate_html_url(url) {
try {
let response = await fetch(url, { method: "HEAD" });
let contentType = response.headers.get("Content-Type");
if (contentType && contentType.includes("text/html")) {
return false;
}
} catch (error) {
console.log("Error fetching URL:", error);
}
return true;
}
async function upload_via_web_link() {
let file_url = web_link.value.url;
if (!file_url) {
frappe.msgprint(__("Invalid URL"));
close_dialog.value = true;
return Promise.reject();
}
file_url = decodeURI(file_url);
const is_valid = await validate_html_url(file_url);
if (!is_valid) {
frappe.msgprint(__("Invalid or unsupported URL"));
return Promise.reject();
}
close_dialog.value = true;
return upload_file({
file_url,

3
frappe/www/printview.py
View file

@ -78,7 +78,8 @@ def get_context(context) -> PrintContext:
body = get_html(
doctype=frappe.form_dict.doctype, name=frappe.form_dict.name, print_format=print_format.name
)
body += trigger_print_script
if cint(frappe.form_dict.trigger_print):
body += trigger_print_script
else:
body = get_rendered_template(
doc,