vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: correct SQL string formatting in get_sql_string method (#34418)

Browse source
This commit is contained in:
Bhavesh Maheshwari 2025-10-15 20:54:14 +05:30 • committed by GitHub
parent 727775f820
commit 2232ff75c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/public/js/frappe/ui/sort_selector.js
View file

@ -196,12 +196,12 @@ frappe.ui.SortSelector = class SortSelector {
}
}
get_sql_string() {
// build string like: `tabSales Invoice`.subject, `tabSales Invoice`.name desc
// build string like: `tabSales Invoice`.`subject`, `tabSales Invoice`.`name` desc
const table_name = "`tab" + this.doctype + "`";
const sort_by = `${table_name}.${this.sort_by}`;
const sort_by = `${table_name}.\`${this.sort_by}\``;
if (!["name", "creation", "modified"].includes(this.sort_by)) {
// add name column for deterministic ordering
return `${sort_by} ${this.sort_order}, ${table_name}.name ${this.sort_order}`;
return `${sort_by} ${this.sort_order}, ${table_name}.\`name\` ${this.sort_order}`;
} else {
return `${sort_by} ${this.sort_order}`;
}