From 2233235ec2aed24f6790b9a63ffaddbe4a18c0a3 Mon Sep 17 00:00:00 2001 From: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Date: Thu, 12 Mar 2020 18:38:45 +0530 Subject: [PATCH] fix: duplicate entry error while renaming item (#9651) Co-authored-by: Rohit Waghchaure --- frappe/model/rename_doc.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py index a42b83fe97..4491a352bc 100644 --- a/frappe/model/rename_doc.py +++ b/frappe/model/rename_doc.py @@ -16,16 +16,15 @@ def update_document_title(doctype, docname, title_field=None, old_title=None, ne """ Update title from header in form view """ + if docname and new_name and not docname == new_name: + docname = rename_doc(doctype=doctype, old=docname, new=new_name, merge=merge) + if old_title and new_title and not old_title == new_title: frappe.db.set_value(doctype, docname, title_field, new_title) frappe.msgprint(_('Saved'), alert=True, indicator='green') - if docname and new_name and not docname == new_name: - return rename_doc(doctype=doctype, old=docname, new=new_name, merge=merge) - return docname - @frappe.whitelist() def rename_doc(doctype, old, new, force=False, merge=False, ignore_permissions=False, ignore_if_exists=False, show_alert=True): """