vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Duplicate review point allocation (#8485)

Browse source
This commit is contained in:
Suraj Shetty 2019-09-24 16:10:43 +05:30 • committed by mergify[bot]
parent c0844f2297
commit 227d27f254
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/social/doctype/energy_point_settings/energy_point_settings.py
View file

@ -21,17 +21,21 @@ def allocate_review_points():
settings.point_allocation_periodicity):
return
user_point_map = {}
for level in settings.review_levels:
create_review_points(level)
users = get_users_with_role(level.role)
for user in users:
user_point_map.setdefault(user, 0)
# to avoid duplicate point allocation
user_point_map[user] = max([user_point_map[user], level.review_points])
for user, points in user_point_map.items():
create_review_points_log(user, points)
settings.last_point_allocation_date = today()
settings.save(ignore_permissions=True)
def create_review_points(level):
users = get_users_with_role(level.role)
for user in users:
create_review_points_log(user, level.review_points)
def can_allocate_today(last_date, periodicity):
if not last_date:
return True