vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(email_account): don't show gmail help text after selecting another provider

Browse source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-05-05 17:09:27 +05:30
parent b923129e53
commit 2299945d03
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 25 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
frappe/email/doctype/email_account/email_account.js
View file

@ -117,23 +117,33 @@ function set_default_max_attachment_size(frm) {
}
function add_helpful_links(frm) {
// For better UX
switch (frm.doc.service) {
case "GMail":
frm.set_df_property(
"password",
"description",
'To generate password visit <a href="https://knowledge.workspace.google.com/kb/how-to-create-app-passwords-000009237"> here'
);
break;
case "Frappe Mail":
frm.set_df_property(
"api_secret",
"description",
'To know more visit <a href="https://github.com/frappe/mail"> here'
);
break;
if (frm.doc.service === "GMail") {
frm.set_df_property(
"password",
"description",
__("To generate password click {0}", [
"<a href='https://knowledge.workspace.google.com/kb/how-to-create-app-passwords-000009237' target='_blank'>" +
__("here") +
"</a>",
])
);
} else {
frm.set_df_property("password", "description", "");
}
if (frm.doc.service === "Frappe Mail") {
frm.set_df_property(
"api_secret",
"description",
__("To know more click {0}", [
"<a href='https://github.com/frappe/mail' target='_blank'>" + __("here") + "</a>",
])
);
} else {
frm.set_df_property("api_secret", "description", "");
}
}
frappe.ui.form.on("Email Account", {
service: function (frm) {
$.each(frappe.email_defaults[frm.doc.service], function (key, value) {