From 2349221255e834b83913d431194aa1884156579c Mon Sep 17 00:00:00 2001 From: P-Godfroid <109596710+P-Godfroid@users.noreply.github.com> Date: Tue, 24 Sep 2024 07:27:40 +0200 Subject: [PATCH] fix(translation): search placeholders (#27812) * Translatable placeholder * Translatable Search word.html * " instead of ' for commiter tool.js * Cleaner way to translate.js * So the issue was prettier.js * Style : prettier.js * style(translation): line break removed from string --- frappe/core/doctype/language/language.py | 3 +-- frappe/templates/discussions/search.html | 2 +- frappe/website/js/website.js | 4 +++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/frappe/core/doctype/language/language.py b/frappe/core/doctype/language/language.py index 049349cd3b..2036d75cae 100644 --- a/frappe/core/doctype/language/language.py +++ b/frappe/core/doctype/language/language.py @@ -77,8 +77,7 @@ def validate_with_regex(name, label): if not pattern.match(name): frappe.throw( _( - """{0} must begin and end with a letter and can only contain letters, - hyphen or underscore.""" + """{0} must begin and end with a letter and can only contain letters, hyphen or underscore.""" ).format(label) ) diff --git a/frappe/templates/discussions/search.html b/frappe/templates/discussions/search.html index 19881dd2b9..82824d0bdf 100644 --- a/frappe/templates/discussions/search.html +++ b/frappe/templates/discussions/search.html @@ -1,2 +1,2 @@ + data-fieldname="feedback_comments" placeholder="{{ _("Search") }} {{ title }}" spellcheck="false"> diff --git a/frappe/website/js/website.js b/frappe/website/js/website.js index 56fc74b5bb..4ae6d614cc 100644 --- a/frappe/website/js/website.js +++ b/frappe/website/js/website.js @@ -425,7 +425,9 @@ frappe.setup_search = function (target, search_scope) { } let $search_input = $(`