vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(query): remove redundant check

Browse source 
`_check_field_permission` already checks `self.apply_permissions`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-12-19 19:04:10 +05:30
parent 2056071f8e
commit 23cdeb7bf5
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
frappe/database/query.py
View file

@ -1166,16 +1166,15 @@ class Engine:
dynamic_field = DynamicTableField.parse(field_name, self.doctype, allow_tab_notation=False)
if dynamic_field:
# Check permissions for dynamic field
if self.apply_permissions:
if isinstance(dynamic_field, ChildTableField):
self._check_field_permission(
dynamic_field.doctype, dynamic_field.fieldname, dynamic_field.parent_doctype
)
elif isinstance(dynamic_field, LinkTableField):
# Check permission for the link field in parent doctype
self._check_field_permission(self.doctype, dynamic_field.link_fieldname)
# Check permission for the target field in linked doctype
self._check_field_permission(dynamic_field.doctype, dynamic_field.fieldname)
if isinstance(dynamic_field, ChildTableField):
self._check_field_permission(
dynamic_field.doctype, dynamic_field.fieldname, dynamic_field.parent_doctype
)
elif isinstance(dynamic_field, LinkTableField):
# Check permission for the link field in parent doctype
self._check_field_permission(self.doctype, dynamic_field.link_fieldname)
# Check permission for the target field in linked doctype
self._check_field_permission(dynamic_field.doctype, dynamic_field.fieldname)
# Apply join for the dynamic field
self.query = dynamic_field.apply_join(self.query, engine=self)
@ -1191,8 +1190,7 @@ class Engine:
)
# Check permissions for simple field
if self.apply_permissions:
self._check_field_permission(self.doctype, field_name)
self._check_field_permission(self.doctype, field_name)
# Create Field object for simple field
return self.table[field_name]