From cef115967b5fd5a6716c1bbab4ca4ef1242a0b61 Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 10:59:38 +0530 Subject: [PATCH 01/11] fix: awesomplete width for filters --- frappe/public/scss/desk/filters.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/frappe/public/scss/desk/filters.scss b/frappe/public/scss/desk/filters.scss index 936dee5a59..1a76db816f 100644 --- a/frappe/public/scss/desk/filters.scss +++ b/frappe/public/scss/desk/filters.scss @@ -29,6 +29,14 @@ margin-bottom: 0; } } + + .awesomplete { + ul[role="listbox"] { + min-width: 100%; + width: auto; + } + } + } .empty-filters { From bc2656dbd85518ca8350e5005ea6b0c08d410a38 Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 11:41:33 +0530 Subject: [PATCH 02/11] fix: remove duplicate variables.scss import --- frappe/public/scss/desk/datepicker.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/frappe/public/scss/desk/datepicker.scss b/frappe/public/scss/desk/datepicker.scss index abe8b59b43..8e709a130e 100644 --- a/frappe/public/scss/desk/datepicker.scss +++ b/frappe/public/scss/desk/datepicker.scss @@ -1,4 +1,3 @@ -@import "variables.scss"; @import "~air-datepicker/dist/css/datepicker.min.css"; .datepicker { From d86832aaf25aec9d80803fcbf7d966821a89ecfc Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 12:34:48 +0530 Subject: [PATCH 03/11] fix: disabled link style --- frappe/public/scss/desk/global.scss | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/frappe/public/scss/desk/global.scss b/frappe/public/scss/desk/global.scss index 5fdc52cd3c..7c1ddde68e 100644 --- a/frappe/public/scss/desk/global.scss +++ b/frappe/public/scss/desk/global.scss @@ -50,13 +50,6 @@ a:focus, outline: 0; } -a.disabled, -a.disabled:hover { - color: var(--text-muted); - cursor: default; - text-decoration: none; -} - a.grey, .sidebar-section a, .control-value a, @@ -75,6 +68,13 @@ a.grey:focus, text-decoration: underline; } +a.disabled, +a.disabled:hover { + color: var(--text-muted); + cursor: default; + text-decoration: none; +} + a.text-muted, a.text-extra-muted { text-decoration: none; From f7c930d50d7baf5b6281c34811de158efa93d5be Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 13:01:13 +0530 Subject: [PATCH 04/11] fix: don't show report builder link on report builder route --- frappe/public/js/frappe/list/list_view_select.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/list/list_view_select.js b/frappe/public/js/frappe/list/list_view_select.js index 0741108176..e1063c5052 100644 --- a/frappe/public/js/frappe/list/list_view_select.js +++ b/frappe/public/js/frappe/list/list_view_select.js @@ -51,10 +51,15 @@ frappe.views.ListViewSelect = class ListViewSelect { action: () => this.set_route("report"), current_view_handler: () => { const reports = this.get_reports(); - this.setup_dropdown_in_sidebar("Report", reports, { - label: __("Report Builder"), - action: () => this.set_route("report") - }); + let default_action = {}; + // Only add action if current route is not report builder + if (frappe.get_route().length > 3) { + default_action = { + label: __("Report Builder"), + action: () => this.set_route("report") + }; + } + this.setup_dropdown_in_sidebar("Report", reports, default_action); } }, Dashboard: { From caf0adaa9d99be84a1ae74ee2f36fdb8871b3501 Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 13:02:01 +0530 Subject: [PATCH 05/11] fix: sidebar dropdown placeholder --- frappe/public/js/frappe/list/list_view_select.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/list/list_view_select.js b/frappe/public/js/frappe/list/list_view_select.js index e1063c5052..58753b7550 100644 --- a/frappe/public/js/frappe/list/list_view_select.js +++ b/frappe/public/js/frappe/list/list_view_select.js @@ -152,8 +152,9 @@ frappe.views.ListViewSelect = class ListViewSelect { ${__("No {} Found", [view])} `; } else { + const page_name = this.get_page_name(); items.map(item => { - if (item.name == this.get_page_name()) { + if (item.name.toLowerCase() == page_name.toLowerCase()) { placeholder = item.name; } html += `
  • ${ From 68bee13f6ed819170c56aeb632c813e20aa0287b Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 15:38:59 +0530 Subject: [PATCH 06/11] fix: title for link field items in awesomplete --- frappe/public/js/frappe/form/controls/link.js | 2 +- frappe/public/scss/desk/filters.scss | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js index 670bb8b3e0..e0a72ed8c1 100644 --- a/frappe/public/js/frappe/form/controls/link.js +++ b/frappe/public/js/frappe/form/controls/link.js @@ -136,7 +136,7 @@ frappe.ui.form.ControlLink = frappe.ui.form.ControlData.extend({ return $('
  • ') .data('item.autocomplete', d) .prop('aria-selected', 'false') - .html('

    ' + html + '

    ') + .html(`

    ${html}

    `) .get(0); }, sort: function() { diff --git a/frappe/public/scss/desk/filters.scss b/frappe/public/scss/desk/filters.scss index 1a76db816f..3680adcf5c 100644 --- a/frappe/public/scss/desk/filters.scss +++ b/frappe/public/scss/desk/filters.scss @@ -34,6 +34,10 @@ ul[role="listbox"] { min-width: 100%; width: auto; + + li { + max-width: 300px; + } } } From 9dd4d4b72a8899683d4feb99b745b08d0d50c3eb Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 16:01:10 +0530 Subject: [PATCH 07/11] fix: show first filter row on opening popover --- frappe/public/js/frappe/ui/filters/filter_list.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/ui/filters/filter_list.js b/frappe/public/js/frappe/ui/filters/filter_list.js index 7f79f8511a..0b2218ceda 100644 --- a/frappe/public/js/frappe/ui/filters/filter_list.js +++ b/frappe/public/js/frappe/ui/filters/filter_list.js @@ -74,8 +74,8 @@ frappe.ui.FilterGroup = class { } this.set_filter_events(); } - - hide_empty_filters && this.toggle_empty_filters(false); + this.toggle_empty_filters(false); + !hide_empty_filters && this.add_filter(this.doctype, 'name'); }); this.filter_button.on('hidden.bs.popover', () => { @@ -286,7 +286,9 @@ frappe.ui.FilterGroup = class { return $(`
    -
    ${__('No filters selected')}
    +
    + ${__('No filters selected')} +
    From f91c9bf46743bb2f29aba7b468ae7c6f3849915b Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 16:25:09 +0530 Subject: [PATCH 08/11] fix: remove hidden_due_do_dependency property for filter field Co-authored-by: Suraj Shetty --- frappe/public/js/frappe/ui/filters/filter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/frappe/public/js/frappe/ui/filters/filter.js b/frappe/public/js/frappe/ui/filters/filter.js index 9bca44a916..945115af82 100644 --- a/frappe/public/js/frappe/ui/filters/filter.js +++ b/frappe/public/js/frappe/ui/filters/filter.js @@ -214,6 +214,7 @@ frappe.ui.Filter = class { df.read_only = 0; df.hidden = 0; df.is_filter = true; + delete df.hidden_due_to_dependency; let c = condition ? condition : this.utils.get_default_condition(df); this.set_condition(c); From c42b5a5cc7bfb9034f7404c29984ca47f46ea2d5 Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 16:20:14 +0530 Subject: [PATCH 09/11] fix: kanban last card cut off --- frappe/public/scss/desk/kanban.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/scss/desk/kanban.scss b/frappe/public/scss/desk/kanban.scss index 9345d61f1f..d879160e21 100644 --- a/frappe/public/scss/desk/kanban.scss +++ b/frappe/public/scss/desk/kanban.scss @@ -32,7 +32,7 @@ border-radius: var(--border-radius); padding: var(--padding-md); min-height: calc(100vh - 250px); - max-height: calc(75vh - 10px); + max-height: calc(100vh - (var(--navbar-height) + var(--page-bottom-margin) + 80px)); .add-card { @include flex(flex, center, center, null); @@ -172,6 +172,10 @@ text-decoration: none; } } + + &:last-child .kanban-card { + margin-bottom: var(--margin-xl); + } } .kanban-card:hover, From c5bd96aea05d2740f689df91d182b31650d90241 Mon Sep 17 00:00:00 2001 From: prssanna Date: Wed, 17 Feb 2021 16:42:42 +0530 Subject: [PATCH 10/11] fix: kanban like --- frappe/public/js/frappe/views/kanban/kanban_board.js | 1 + 1 file changed, 1 insertion(+) diff --git a/frappe/public/js/frappe/views/kanban/kanban_board.js b/frappe/public/js/frappe/views/kanban/kanban_board.js index c6173b5a65..8711deb4b4 100644 --- a/frappe/public/js/frappe/views/kanban/kanban_board.js +++ b/frappe/public/js/frappe/views/kanban/kanban_board.js @@ -704,6 +704,7 @@ frappe.provide("frappe.views"); name: card.name, title: card[state.card_meta.title_field.fieldname], creation: moment(card.creation).format('MMM DD, YYYY'), + _liked_by: card._liked_by, tags: card._user_tags, column: card[state.board.field_name], assigned_list: card.assigned_list || assigned_list, From 24aabd2b023c2280af9622487ba115c2dfad9c84 Mon Sep 17 00:00:00 2001 From: prssanna Date: Thu, 18 Feb 2021 11:24:25 +0530 Subject: [PATCH 11/11] fix: ui tests --- cypress/support/commands.js | 1 - 1 file changed, 1 deletion(-) diff --git a/cypress/support/commands.js b/cypress/support/commands.js index 416d782ffe..1964b96d70 100644 --- a/cypress/support/commands.js +++ b/cypress/support/commands.js @@ -312,7 +312,6 @@ Cypress.Commands.add('add_filter', () => { cy.get('.filter-section .filter-button').click(); cy.wait(300); cy.get('.filter-popover').should('exist'); - cy.get('.filter-popover').find('.add-filter').click(); }); Cypress.Commands.add('clear_filters', () => {