vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #28355 from Centura-AG/refactor/send-notification-by-channel

Browse source
This commit is contained in:
Suraj Shetty 2024-11-04 23:44:34 +05:30 • committed by GitHub
commit 2628225a05
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
frappe/email/doctype/notification/notification.py
View file

@ -333,21 +333,8 @@ def get_context(context):
if self.is_standard:
self.load_standard_properties(context)
try:
if self.channel == "Email":
self.send_an_email(doc, context)
if self.channel == "Slack":
self.send_a_slack_msg(doc, context)
if self.channel == "SMS":
self.send_sms(doc, context)
if self.channel == "System Notification" or self.send_system_notification:
self.create_system_notification(doc, context)
except Exception:
self.log_error("Failed to send Notification")
self.send_notification_by_channel(doc, context)
if self.set_property_after_alert:
allow_update = True
@ -376,6 +363,20 @@ def get_context(context):
except Exception:
self.log_error("Document update failed")
def send_notification_by_channel(self, doc, context):
"""Send notification based on the specified channel."""
try:
if self.channel == "Email":
self.send_an_email(doc, context)
elif self.channel == "Slack":
self.send_a_slack_msg(doc, context)
elif self.channel == "SMS":
self.send_sms(doc, context)
elif self.channel == "System Notification" or self.send_system_notification:
self.create_system_notification(doc, context)
except Exception:
self.log_error("Failed to send Notification")
def create_system_notification(self, doc, context):
subject = self.subject
if "{" in subject: