vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test: verify ALL translation file syntax

Browse source
This commit is contained in:
Ankush Menat 2022-05-13 15:46:53 +05:30 • committed by Ankush Menat
parent 55def8b718
commit 26b54221ea
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frappe/tests/test_translate.py
View file

@ -8,7 +8,7 @@ from unittest.mock import patch
import frappe
import frappe.translate
from frappe import _
from frappe.translate import get_language, get_parent_language
from frappe.translate import get_language, get_parent_language, get_translation_dict_from_file
from frappe.utils import set_request
dirname = os.path.dirname(__file__)
@ -119,6 +119,23 @@ class TestTranslate(unittest.TestCase):
return_val = get_language()
self.assertNotIn(return_val, [third_lang, get_parent_language(third_lang)])
def test_load_all_translate_files(self):
"""Load all CSV files to ensure they have correct format"""
verify_translation_files("frappe")
def verify_translation_files(app):
"""Function to verify translation file syntax in app."""
# Do not remove/rename this, other apps depend on it to test their translations
from pathlib import Path
translations_dir = Path(frappe.get_app_path(app)) / "translations"
for file in translations_dir.glob("*.csv"):
lang = file.stem # basename of file = lang
get_translation_dict_from_file(file, lang, app, throw=True)
expected_output = [
("Warning: Unable to find {0} in any table related to {1}", "This is some context", 2),

4
frappe/translate.py
View file

@ -306,7 +306,7 @@ def load_lang(lang, apps=None):
return out or {}
def get_translation_dict_from_file(path, lang, app):
def get_translation_dict_from_file(path, lang, app, throw=False):
"""load translation dict from given path"""
translation_map = {}
if os.path.exists(path):
@ -323,6 +323,8 @@ def get_translation_dict_from_file(path, lang, app):
app=app, lang=lang, values=cstr(item)
)
frappe.log_error(message=msg, title="Error in translation file")
if throw:
frappe.throw(msg, title="Error in translation file")
return translation_map