vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: rearrange checks, inline and cast super args

Browse source 
Co-authored-by: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
This commit is contained in:
Ankush Menat 2025-06-10 23:23:56 +05:30 • committed by Ankush Menat
parent e69f79e2ae
commit 26cf77562c
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frappe/model/document.py
View file

@ -9,7 +9,7 @@ from collections.abc import Generator, Iterable
from contextlib import contextmanager
from functools import wraps
from types import MappingProxyType
from typing import TYPE_CHECKING, Any, Literal, Optional, TypeAlias, Union, overload
from typing import TYPE_CHECKING, Any, Literal, Optional, TypeAlias, Union, cast, overload
from typing_extensions import Self, override
from werkzeug.exceptions import NotFound
@ -1982,11 +1982,12 @@ class LazyDocument:
self.__dict__.pop(fieldname, None)
@override
def get(self: Document, key, *args, **kwags):
def get(self: Document, key, filters=None, limit=None, default=None):
if isinstance(key, str):
# Trigger populating of __dict__
_ = getattr(self, key, None)
return super().get(key, *args, **kwags)
getattr(self, key, None)
parent = cast(Document, super())
return parent.get(key, filters, limit, default)
@override
def db_update_all(self):
@ -2008,9 +2009,11 @@ class LazyChildTable:
def __get__(self, doc: Document, objtype=None):
# Note: avoid any high level access here, can cause recursion
children = doc._load_child_table_from_db(self.fieldname, self.doctype) or []
assert self.fieldname not in doc.__dict__, "Descriptor should not override existing values"
doc.__dict__[self.fieldname] = []
fieldname = self.fieldname
__dict = doc.__dict__
assert fieldname not in __dict, "Descriptor should not override existing values"
children = doc._load_child_table_from_db(fieldname, self.doctype) or []
__dict[fieldname] = []
# Update __dict__ and convert to Document objects
doc.extend(self.fieldname, children)
return doc.__dict__[self.fieldname]
doc.extend(fieldname, children)
return __dict[fieldname]