vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: Avoid ordering for link field checks (#38928)

Browse source
This commit is contained in:
Ankush Menat 2026-04-27 15:06:30 +05:30 • committed by GitHub
parent e13017794b
commit 27712f3c76
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/model/delete_doc.py
View file

@ -138,7 +138,7 @@ def delete_doc(
):
try:
delete_controllers(name, doc.module)
except (OSError, KeyError):
except OSError, KeyError:
# in case a doctype doesnt have any controller code nor any app and module
pass
@ -148,7 +148,7 @@ def delete_doc(
# Lock the doc without waiting
try:
frappe.db.get_value(doctype, name, for_update=True, wait=False)
except (frappe.QueryTimeoutError, frappe.QueryDeadlockError):
except frappe.QueryTimeoutError, frappe.QueryDeadlockError:
frappe.throw(
_(
"This document can not be deleted right now as it's being modified by another user. Please try again after some time."
@ -339,7 +339,13 @@ def get_linked_docs(doc, method="Delete") -> list[dict]:
if meta.istable:
fields.extend(["parent", "parenttype"])
for item in frappe.db.get_values(link_dt, {link_field: doc.name}, fields, as_dict=True):
for item in frappe.db.get_values(
link_dt,
{link_field: doc.name},
fields,
as_dict=True,
order_by=None,
):
# available only in child table cases
item_parent = getattr(item, "parent", None)
linked_parent_doctype = item.parenttype if item_parent else link_dt