From 27f104bba657483d911cd31ef91ffff5eb51dc20 Mon Sep 17 00:00:00 2001 From: MeIchthys Date: Mon, 5 Jan 2026 13:08:30 +0000 Subject: [PATCH] fix: Don't `set_status` to 'Closed' when status is already "Closed" (#35621) Co-authored-by: mgieger --- frappe/desk/form/assign_to.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/desk/form/assign_to.py b/frappe/desk/form/assign_to.py index 655d81a7ab..bcebd4db0e 100644 --- a/frappe/desk/form/assign_to.py +++ b/frappe/desk/form/assign_to.py @@ -155,7 +155,7 @@ def close_all_assignments(doctype, name, ignore_permissions=False): assignments = frappe.get_all( "ToDo", fields=["allocated_to", "name"], - filters=dict(reference_type=doctype, reference_name=name, status=("!=", "Cancelled")), + filters=dict(reference_type=doctype, reference_name=name, status=("not in", ["Cancelled", "Closed"])), ) if not assignments: return False