vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: Fractional ratings patch

Browse source 
* Change column types of rating fields
* Workaround added for truncated/NULL values

Co-authored-by: Ankush Menat <me@ankush.dev>
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
This commit is contained in:
Gavin D'souza 2021-12-23 18:34:36 +05:30
parent d1e229de2c
commit 27f8a1ea56
1 changed files with 39 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
frappe/patches/v14_0/save_ratings_in_fraction.py
View file

@ -1,12 +1,44 @@
import frappe
from frappe.query_builder import DocType
def execute():
rating_fields = frappe.get_all("DocField", fields=["parent", "fieldname"], filters={"fieldtype": "Rating"})
rating_fields = frappe.get_all(
"DocField", fields=["parent", "fieldname"], filters={"fieldtype": "Rating"}
)
custom_rating_fields = frappe.get_all("Custom Field", fields=["dt", "fieldname"], filters={"fieldtype": "Rating"})
custom_rating_fields = frappe.get_all(
"Custom Field", fields=["dt", "fieldname"], filters={"fieldtype": "Rating"}
)
for field in rating_fields + custom_rating_fields:
doctype_name = field.get("parent") or field.get("dt")
doctype = frappe.qb.DocType(doctype_name)
field = field.fieldname
(frappe.qb.update(doctype_name).set(doctype[field], doctype[field]/5)).run()
for _field in rating_fields + custom_rating_fields:
doctype_name = _field.get("parent") or _field.get("dt")
doctype = DocType(doctype_name)
field = _field.fieldname
# update NULL values to 0 to avoid data truncated error (temp)
# commit for upcoming DLL
frappe.qb.update(doctype).set(
doctype[field], 0
).where(
doctype[field].isnull()
).run()
frappe.db.commit()
# alter column types for rating fieldtype
frappe.db.change_column_type(doctype_name, column=field, type="decimal(3,2)")
# update data: int => decimal
frappe.qb.update(doctype).set(
doctype[field], doctype[field] / 5
).run()
# revert 0 to NULL conversion
frappe.qb.update(doctype).set(
doctype[field], None
).where(
doctype[field] == 0
).run()
# commit to flush updated rows
frappe.db.commit()