vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: better permission check for single doctypes

Browse source
This commit is contained in:
Sagar Vora 2025-12-22 12:13:26 +05:30
parent 584e629c5f
commit 2882ed4e69
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/permissions.py
View file

@ -130,6 +130,10 @@ def has_permission(
meta = frappe.get_meta(doctype)
# docname == doctype for single doctypes
if not doc and meta.issingle:
doc = meta.name
if doc:
if isinstance(doc, str | int):
# perf: Avoid loading child tables for perm checks
@ -140,7 +144,9 @@ def has_permission(
"Permission check failed from role permission system. Check if user's role grant them permission to the document."
)
msg = _("User {0} does not have access to this document").format(frappe.bold(user))
if frappe.has_permission(doc.doctype):
if meta.issingle:
msg += f": {_(doc.doctype)}"
elif has_permission(doc.doctype):
msg += f": {_(doc.doctype)} - {doc.name}"
push_perm_check_log(msg, debug=debug)
else: