From 28a5e9fee2db70ccfb271a7c0f8d00780787d364 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Tue, 18 Jun 2024 18:20:56 +0530 Subject: [PATCH] fix(query_report): don't follow reference report for `prepared_report` field This disallows people from doing things like disabling prepared report on custom reports Signed-off-by: Akhil Narang --- frappe/desk/query_report.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frappe/desk/query_report.py b/frappe/desk/query_report.py index 3e624056a2..2f19ae6645 100644 --- a/frappe/desk/query_report.py +++ b/frappe/desk/query_report.py @@ -34,6 +34,9 @@ def get_report_doc(report_name): doc.custom_filters = data.get("filters") doc.is_custom_report = True + # Follow whatever the custom report has set for prepared report field + doc.prepared_report = custom_report_doc.prepared_report + if not doc.is_permitted(): frappe.throw( _("You don't have access to Report: {0}").format(report_name),