vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(python 3.8): explicit digestmod in hmac.new

Browse source
This commit is contained in:
Sagar Vora 2020-05-03 18:15:22 +05:30 • committed by GitHub
parent aacfdeeb10
commit 28cd2c66f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/utils/verified_command.py
View file

@ -2,7 +2,7 @@
# MIT License. See license.txt
from __future__ import unicode_literals
import hmac
import hmac, hashlib
from six.moves.urllib.parse import urlencode
from frappe import _
@ -17,7 +17,7 @@ def get_signed_params(params):
if not isinstance(params, string_types):
params = urlencode(params)
signature = hmac.new(params.encode())
signature = hmac.new(params.encode(), digestmod=hashlib.md5)
signature.update(get_secret().encode())
return params + "&_signature=" + signature.hexdigest()
@ -35,7 +35,7 @@ def verify_request():
if signature_string in query_string:
params, signature = query_string.split(signature_string)
given_signature = hmac.new(params.encode('utf-8'))
given_signature = hmac.new(params.encode('utf-8'), digestmod=hashlib.md5)
given_signature.update(get_secret().encode())
valid = signature == given_signature.hexdigest()
@ -58,7 +58,7 @@ def get_signature(params, nonce, secret=None):
if not secret:
secret = frappe.local.conf.get("secret") or "secret"
signature = hmac.new(str(nonce))
signature = hmac.new(str(nonce), digestmod=hashlib.md5)
signature.update(secret)
signature.update(params)
return signature.hexdigest()