Merge pull request #32222 from sagarvora/type-hints

This commit is contained in:
Sagar Vora 2025-04-21 15:34:35 +05:30 committed by GitHub
commit 291edf1594
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions

View file

@ -295,7 +295,7 @@ def bulk_update(docs):
@frappe.whitelist()
def has_permission(doctype, docname, perm_type="read"):
def has_permission(doctype: str, docname: str, perm_type: str = "read"):
"""Return a JSON with data whether the document has the requested permission.
:param doctype: DocType of the document to be checked
@ -306,7 +306,7 @@ def has_permission(doctype, docname, perm_type="read"):
@frappe.whitelist()
def get_doc_permissions(doctype, docname):
def get_doc_permissions(doctype: str, docname: str):
"""Return an evaluated document permissions dict like `{"read":1, "write":1}`.
:param doctype: DocType of the document to be evaluated
@ -317,7 +317,7 @@ def get_doc_permissions(doctype, docname):
@frappe.whitelist()
def get_password(doctype, name, fieldname):
def get_password(doctype: str, name: str, fieldname: str):
"""Return a password type property. Only applicable for System Managers
:param doctype: DocType of the document that holds the password
@ -387,7 +387,7 @@ def attach_file(
@frappe.whitelist()
@http_cache(max_age=10 * 60)
def is_document_amended(doctype, docname):
def is_document_amended(doctype: str, docname: str):
if frappe.permissions.has_permission(doctype):
try:
return frappe.db.exists(doctype, {"amended_from": docname})

View file

@ -660,13 +660,13 @@ def check_webform_perm(doctype, name):
@frappe.whitelist(allow_guest=True)
def get_web_form_filters(web_form_name):
def get_web_form_filters(web_form_name: str):
web_form = frappe.get_doc("Web Form", web_form_name)
return [field for field in web_form.web_form_fields if field.show_in_filter]
@frappe.whitelist(allow_guest=True)
def get_form_data(doctype, docname=None, web_form_name=None):
def get_form_data(doctype: str, docname: str | None = None, web_form_name: str | None = None):
web_form = frappe.get_doc("Web Form", web_form_name)
if web_form.login_required and frappe.session.user == "Guest":