vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: allow to reset rating input if not mandatory

Browse source 
If a rating field is not mandatory and the user selects the same
rating again then it should reset the rating by setting value to 0.

Fixes #27922
This commit is contained in:
Aryan Kaushik 2024-09-27 20:07:56 +00:00
parent 7bc23e783e
commit 2992e6fcb4
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/public/js/frappe/form/controls/rating.js
View file

@ -47,12 +47,25 @@ frappe.ui.form.ControlRating = class ControlRating extends frappe.ui.form.Contro
let star_value = el.data("rating");
let left_half = false;
let cls = "star-click";
let out_of_ratings = this.df.options || 5;
if (!click) cls = "star-hover";
if (ev.pageX - el.offset().left < el.width() / 2) {
left_half = true;
star_value--;
}
if (click && !this.df.reqd) {
let fractional_star_value = star_value;
if (left_half) {
fractional_star_value += 0.5;
}
if (this.get_value() == fractional_star_value / out_of_ratings) {
star_value = 0;
left_half = false;
}
}
el.parent()
.children("svg")
.each(function (e) {
@ -67,7 +80,6 @@ frappe.ui.form.ControlRating = class ControlRating extends frappe.ui.form.Contro
}
});
if (click) {
let out_of_ratings = this.df.options || 5;
star_value = star_value / out_of_ratings;
this.validate_and_set_in_model(star_value, ev);