vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #25867 from akhilnarang/fix-unhandled-TypeError

Browse source 
fix(layout): handle `fieldobj` being null
This commit is contained in:
Akhil Narang 2024-04-09 11:56:18 +05:30 • committed by GitHub
commit 2a1d87590c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/public/js/frappe/form/layout.js
View file

@ -212,6 +212,10 @@ frappe.ui.form.Layout = class Layout {
const parent = this.column.form.get(0);
const fieldobj = this.init_field(df, parent, render);
// An invalid control name will return in a null fieldobj
if (!fieldobj) return;
this.fields_list.push(fieldobj);
this.fields_dict[df.fieldname] = fieldobj;
@ -234,7 +238,11 @@ frappe.ui.form.Layout = class Layout {
layout: this,
});
fieldobj.layout = this;
// make_control can return null for invalid control names
if (fieldobj) {
fieldobj.layout = this;
}
return fieldobj;
}