From 4dd03618d6c016fd0c4730d6fab91dd17fd89684 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Sat, 10 Nov 2018 17:03:24 +0530 Subject: [PATCH] Revert feature, listView filter shows hidden field --- frappe/public/js/frappe/ui/filters/filters.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/ui/filters/filters.js b/frappe/public/js/frappe/ui/filters/filters.js index b283b0133e..df161892f7 100644 --- a/frappe/public/js/frappe/ui/filters/filters.js +++ b/frappe/public/js/frappe/ui/filters/filters.js @@ -642,7 +642,7 @@ frappe.ui.FieldSelect = Class.extend({ // child tables $.each(me.table_fields, function(i, table_df) { - if(table_df.options && !table_df.hidden) { + if(table_df.options) { var child_table_fields = [].concat(frappe.meta.docfield_list[table_df.options]); $.each(frappe.utils.sort(child_table_fields, "label", "string"), function(i, df) { // show fields where user has read access and if report hide flag is not set @@ -664,7 +664,7 @@ frappe.ui.FieldSelect = Class.extend({ var table = df.parent; } if(frappe.model.no_value_type.indexOf(df.fieldtype) == -1 && - !(me.fields_by_name[df.parent] && me.fields_by_name[df.parent][df.fieldname]) && !df.hidden) { + !(me.fields_by_name[df.parent] && me.fields_by_name[df.parent][df.fieldname])) { this.options.push({ label: label, value: table + "." + df.fieldname,