vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(minor): tests

Browse source 
(cherry picked from commit 868228bdea)
This commit is contained in:
Rushabh Mehta 2021-03-30 15:50:47 +05:30 • committed by mergify-bot
parent cf526d714d
commit 2acaf1a464
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/desk/reportview.py
View file

@ -60,9 +60,11 @@ def validate_args(data):
def validate_fields(data):
expand_fields(data)
update_star_field_param(data)
if update_wildcard_field_param(data):
# no need to validate wildcard fields
return
for field in data.fields:
for field in data.fields or []:
fieldname = extract_fieldname(field)
if is_standard(fieldname):
continue
@ -163,10 +165,13 @@ def get_meta_and_docfield(fieldname, data):
df = meta.get_field(fieldname)
return meta, df
def update_star_field_param(data):
def update_wildcard_field_param(data):
if ((isinstance(data.fields, string_types) and data.fields == "*")
or (isinstance(data.fields, (list, tuple)) and len(data.fields) == 1 and data.fields[0] == "*")):
data.fields = frappe.db.get_table_columns(data.doctype)
return True
return False
def clean_params(data):

2
frappe/frappeclient.py
View file

@ -86,7 +86,7 @@ class FrappeClient(object):
'cmd': 'logout',
}, verify=self.verify, headers=self.headers)
def get_list(self, doctype, fields='"*"', filters=None, limit_start=0, limit_page_length=0):
def get_list(self, doctype, fields='["name"]', filters=None, limit_start=0, limit_page_length=0):
"""Returns list of records of a particular type"""
if not isinstance(fields, string_types):
fields = json.dumps(fields)