From 2bd2ee36557780d03086d986e945f372604f47de Mon Sep 17 00:00:00 2001 From: Anupam Date: Mon, 20 Sep 2021 10:13:14 +0530 Subject: [PATCH] fix: sider issues --- .../network_printer_settings/network_printer_settings.js | 4 +--- frappe/printing/page/print/print.js | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/frappe/printing/doctype/network_printer_settings/network_printer_settings.js b/frappe/printing/doctype/network_printer_settings/network_printer_settings.js index 6e33e20792..043afd388f 100644 --- a/frappe/printing/doctype/network_printer_settings/network_printer_settings.js +++ b/frappe/printing/doctype/network_printer_settings/network_printer_settings.js @@ -3,9 +3,7 @@ frappe.ui.form.on('Network Printer Settings', { onload (frm) { - if (!frm.is_new()) { - frm.trigger("connect_print_server"); - } + frm.trigger("connect_print_server"); }, server_ip (frm) { frm.trigger("connect_print_server"); diff --git a/frappe/printing/page/print/print.js b/frappe/printing/page/print/print.js index 0b2620c3f4..d3b1c69815 100644 --- a/frappe/printing/page/print/print.js +++ b/frappe/printing/page/print/print.js @@ -536,16 +536,15 @@ frappe.ui.form.PrintView = class { } } network_printer_setting_dialog(callback) { - let me = this; frappe.call({ method: 'frappe.printing.doctype.network_printer_settings.network_printer_settings.get_network_printer_settings', callback: function(r) { - if(r.message) { + if (r.message) { let d = new frappe.ui.Dialog({ title: __('Select Network Printer'), fields: [ { - "label" : "Printer", + "label": "Printer", "fieldname": "printer", "fieldtype": "Select", "reqd": 1,