vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: use property image_field and check for http link

Browse source
This commit is contained in:
Prssanna Desai 2019-04-24 15:09:24 +05:30
parent d82230bcb7
commit 2c1e20496a
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/desk/link_preview.py
View file

@ -9,8 +9,7 @@ def get_preview_data(doctype, docname, fields):
preview_fields.append(frappe.get_meta(doctype).get_title_field())
if 'name' not in fields:
preview_fields.append('name')
if frappe.get_meta(doctype).has_field('image'):
preview_fields.append('image')
preview_fields.append(frappe.get_meta(doctype).image_field)
preview_data = frappe.get_list(doctype, filters={
'name': docname

5
frappe/public/js/frappe/ui/link_preview.js
View file

@ -16,6 +16,9 @@ frappe.ui.LinkPreview = class {
if(!this.element.parents().find('.popover').length) {
if(this.element.attr('href')) {
this.link = this.element.attr('href');
if(this.link.startsWith('http')) {
return;
}
let details = this.get_details();
this.name = details.name;
this.doctype = details.doctype;
@ -34,7 +37,7 @@ frappe.ui.LinkPreview = class {
}
this.popover = this.element.data("bs.popover");
if(this.name && this.doctype && this.doctype!=='files') {
if(this.name && this.doctype) {
this.setup_popover_control(e);
}
}