vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix!: Change count(cache=True) implmentation (#32779)

Browse source 
This makes cache implementation uniform for all methods on db API. It's
weird that this specific method was caching in redis, which defies
expectations.
This commit is contained in:
Ankush Menat 2025-06-04 19:15:27 +05:30 • committed by GitHub
parent 91ee97b78f
commit 2d14918814
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/database/database.py
View file

@ -1252,10 +1252,10 @@ class Database:
def count(self, dt, filters=None, debug=False, cache=False, distinct: bool = True):
"""Return `COUNT(*)` for given DocType and filters."""
cache_key = (dt, "COUNT(*)")
if cache and not filters:
cache_count = frappe.cache.get_value(f"doctype:count:{dt}")
if cache_count is not None:
return cache_count
if cache_key in self.value_cache:
return self.value_cache[cache_key]
count = frappe.qb.get_query(
table=dt,
filters=filters,
@ -1264,7 +1264,7 @@ class Database:
validate_filters=True,
).run(debug=debug)[0][0]
if not filters and cache:
frappe.cache.set_value(f"doctype:count:{dt}", count, expires_in_sec=86400)
self.value_cache[cache_key] = count
return count
def estimate_count(self, doctype: str) -> int: