vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Append to condition misleading message (#17696)

Browse source 
* Update Append to doctype description

Hello,

To append email to a doctype to enable automatic creation, there are two required fields listed
![image](https://user-images.githubusercontent.com/109596710/182173486-d7141ec9-451d-4de9-8303-a8e8dbd289bf.png)

However, there is a third one required which is lacking in the above description (as seen below), because the email settings of the document must be enabled.
![image_2022-08-01_163225456](https://user-images.githubusercontent.com/109596710/182173390-7285e92f-6f04-4e42-a215-ad45e50e0fd3.png)

I propose to simply modify the sentence to the following :

Append as communication against this DocType (must have fields ("Status", "Subject") and "Sender" defined in the related doctype Email Settings).


To avoid any problem, in the code, it becomes the following : 
Append as communication against this DocType (must have fields (\"Status\", \"Subject\") and \"Sender\" defined in the related doctype Email Settings).


The same must be applied in email_domain.json and in lots of csv in translations of course.

Pierre

* Update email_domain.json

* Updated sentence email account

* Updated sentence of email domain

* More brackets

* More brackets

* Typo

* Update email_account.json

* No dot
This commit is contained in:
P-Godfroid 2022-08-02 11:50:19 +02:00 • committed by GitHub
parent 63c3c8ff84
commit 2d1fe02dba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/email/doctype/email_account/email_account.json
View file

@ -214,7 +214,7 @@
},
{
"depends_on": "eval: doc.enable_incoming && !doc.use_imap",
"description": "Append as communication against this DocType (must have fields, \"Status\", \"Subject\")",
"description": "Append as communication against this DocType (must have field \"Status\" and both \"Sender\" and \"Subject\" defined in the related doctype Email Settings)",
"fieldname": "append_to",
"fieldtype": "Link",
"hide_days": 1,
@ -630,4 +630,4 @@
"sort_order": "DESC",
"states": [],
"track_changes": 1
}
}

4
frappe/email/doctype/email_domain/email_domain.json
View file

@ -73,7 +73,7 @@
"label": "Attachment Limit (MB)"
},
{
"description": "Append as communication against this DocType (must have fields, \"Status\", \"Subject\")",
"description": "Append as communication against this DocType (must have field \"Status\" and both \"Sender\" and \"Subject\" defined in the related doctype Email Settings)",
"fieldname": "append_to",
"fieldtype": "Link",
"hidden": 1,
@ -143,4 +143,4 @@
],
"sort_field": "modified",
"sort_order": "DESC"
}
}