From 2e9dcc591263c19f3e3e87b4ea0204233b830f1b Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 1 Dec 2022 15:55:29 +0530
Subject: [PATCH] revert: cannot drag alert on dragging standard fields

not working as expected
---
 frappe/public/js/form_builder/components/Column.vue    |  3 ---
 frappe/public/js/form_builder/components/Field.vue     |  3 ---
 frappe/public/js/form_builder/components/Section.vue   |  3 ---
 frappe/public/js/form_builder/components/Tabs.vue      |  3 ---
 .../form_builder/components/controls/CodeControl.vue   |  1 +
 .../form_builder/components/controls/TextControl.vue   |  2 +-
 frappe/public/js/form_builder/store.js                 | 10 ----------
 7 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/frappe/public/js/form_builder/components/Column.vue b/frappe/public/js/form_builder/components/Column.vue
index b5462b44ce..45017748ed 100644
--- a/frappe/public/js/form_builder/components/Column.vue
+++ b/frappe/public/js/form_builder/components/Column.vue
@@ -73,9 +73,6 @@ function move_columns_to_section() {
 		@click.stop="store.selected_field = column.df"
 		@mouseover.stop="hovered = true"
 		@mouseout.stop="hovered = false"
-		@mousemove.stop="store.drag = true"
-		@mousedown.stop="store.drag = false"
-		@mouseup.stop="store.start_drag(column)"
 	>
 		<div class="column-actions" :hidden="store.read_only">
 			<button
diff --git a/frappe/public/js/form_builder/components/Field.vue b/frappe/public/js/form_builder/components/Field.vue
index 7e3eba81fd..bcdd667474 100644
--- a/frappe/public/js/form_builder/components/Field.vue
+++ b/frappe/public/js/form_builder/components/Field.vue
@@ -40,9 +40,6 @@ function move_fields_to_column() {
 		@click.stop="store.selected_field = field.df"
 		@mouseover.stop="hovered = true"
 		@mouseout.stop="hovered = false"
-		@mousemove.stop="store.drag = true"
-		@mousedown.stop="store.drag = false"
-		@mouseup.stop="store.start_drag(field)"
 	>
 		<component :is="component" :df="field.df">
 			<template #label>
diff --git a/frappe/public/js/form_builder/components/Section.vue b/frappe/public/js/form_builder/components/Section.vue
index e83e3437c9..5366665664 100644
--- a/frappe/public/js/form_builder/components/Section.vue
+++ b/frappe/public/js/form_builder/components/Section.vue
@@ -82,9 +82,6 @@ function move_sections_to_tab() {
 			@click.stop="select_section"
 			@mouseover.stop="hovered = true"
 			@mouseout.stop="hovered = false"
-			@mousemove.stop="store.drag = true"
-			@mousedown.stop="store.drag = false"
-			@mouseup.stop="store.start_drag(section)"
 		>
 			<div
 				:class="[
diff --git a/frappe/public/js/form_builder/components/Tabs.vue b/frappe/public/js/form_builder/components/Tabs.vue
index ade815bf98..8e05550da5 100644
--- a/frappe/public/js/form_builder/components/Tabs.vue
+++ b/frappe/public/js/form_builder/components/Tabs.vue
@@ -125,9 +125,6 @@ function remove_tab() {
 					@dragstart="dragged = true"
 					@dragend="dragged = false"
 					@dragover="drag_over(element)"
-					@mousemove.stop="store.drag = true"
-					@mousedown.stop="store.drag = false"
-					@mouseup.stop="store.start_drag(element)"
 				>
 					<EditableInput
 						:text="element.df.label"
diff --git a/frappe/public/js/form_builder/components/controls/CodeControl.vue b/frappe/public/js/form_builder/components/controls/CodeControl.vue
index aeb0a2b1ef..d42bc43f81 100644
--- a/frappe/public/js/form_builder/components/controls/CodeControl.vue
+++ b/frappe/public/js/form_builder/components/controls/CodeControl.vue
@@ -1,3 +1,4 @@
+<!-- Used as Code, HTML Editor, Markdown Editor & JSON Control -->
 <script setup>
 import { computed, onMounted, ref, useSlots, watch } from "vue";
 import { useStore } from "../../store";
diff --git a/frappe/public/js/form_builder/components/controls/TextControl.vue b/frappe/public/js/form_builder/components/controls/TextControl.vue
index 80f6a1e8b7..19fd3971d2 100644
--- a/frappe/public/js/form_builder/components/controls/TextControl.vue
+++ b/frappe/public/js/form_builder/components/controls/TextControl.vue
@@ -1,4 +1,4 @@
-<!-- Used as Text & Small Text, Long Text Control -->
+<!-- Used as Text, Small Text & Long Text Control -->
 <script setup>
 import { useStore } from "../../store";
 import { useSlots, ref, computed, watch } from "vue";
diff --git a/frappe/public/js/form_builder/store.js b/frappe/public/js/form_builder/store.js
index ed1e5a19bc..bd907d8f92 100644
--- a/frappe/public/js/form_builder/store.js
+++ b/frappe/public/js/form_builder/store.js
@@ -195,15 +195,5 @@ export const useStore = defineStore("form-builder-store", {
 		get_layout() {
 			return create_layout(this.doc.fields);
 		},
-		start_drag(field) {
-			if (this.drag && this.has_standard_field(field)) {
-				frappe.show_alert({
-					message: __(
-						"Standard field or custom tab, section, or column containing standard fields cannot be dragged"
-					),
-					indicator: "yellow",
-				});
-			}
-		},
 	},
 });