From 2ed85ca9f2cd0797da776631d637336ef36d849c Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sat, 5 Aug 2023 11:15:11 +0530 Subject: [PATCH] refactor: check license names before sending text File might not exist. --- frappe/core/doctype/package/package.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/frappe/core/doctype/package/package.py b/frappe/core/doctype/package/package.py index a3be3ea7f4..812a589940 100644 --- a/frappe/core/doctype/package/package.py +++ b/frappe/core/doctype/package/package.py @@ -6,6 +6,12 @@ import os import frappe from frappe.model.document import Document +LICENSES = ( + "GNU Affero General Public License", + "GNU General Public License", + "MIT License", +) + class Package(Document): # begin: auto-generated types @@ -29,6 +35,7 @@ class Package(Document): @frappe.whitelist() -def get_license_text(license_type): - with open(os.path.join(os.path.dirname(__file__), "licenses", license_type + ".md")) as textfile: - return textfile.read() +def get_license_text(license_type: str) -> str | None: + if license_type in LICENSES: + with open(os.path.join(os.path.dirname(__file__), "licenses", license_type + ".md")) as textfile: + return textfile.read()