From 2f334baba5aef8243077b1c8eedc1c177ad2fd2d Mon Sep 17 00:00:00 2001
From: Prateeksha Singh <pratu16x7@gmail.com>
Date: Tue, 29 Jan 2019 12:59:38 +0530
Subject: [PATCH] remove(add_to_desktop): remove from all views

---
 frappe/public/js/frappe/form/toolbar.js             |  7 -------
 frappe/public/js/frappe/list/list_view.js           |  7 -------
 .../public/js/frappe/views/reports/query_report.js  |  7 +------
 .../public/js/frappe/views/reports/report_view.js   | 13 +------------
 frappe/public/js/frappe/views/reports/reportview.js |  5 -----
 frappe/public/js/frappe/views/treeview.js           |  8 --------
 6 files changed, 2 insertions(+), 45 deletions(-)

diff --git a/frappe/public/js/frappe/form/toolbar.js b/frappe/public/js/frappe/form/toolbar.js
index 99d913f1cd..44898c3b5e 100644
--- a/frappe/public/js/frappe/form/toolbar.js
+++ b/frappe/public/js/frappe/form/toolbar.js
@@ -153,13 +153,6 @@ frappe.ui.form.Toolbar = Class.extend({
 		this.page.add_menu_item(__("Reload"), function() {
 			me.frm.reload_doc();}, true);
 
-		// add to desktop
-		if(me.frm.meta.issingle) {
-			this.page.add_menu_item(__('Add to Desktop'), function () {
-				frappe.add_to_desktop(me.frm.doctype, me.frm.doctype);
-			}, true);
-		}
-
 		// delete
 		if((cint(me.frm.doc.docstatus) != 1) && !me.frm.doc.__islocal
 			&& frappe.model.can_delete(me.frm.doctype)) {
diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js
index 6052baa6c4..9d47f283c8 100644
--- a/frappe/public/js/frappe/list/list_view.js
+++ b/frappe/public/js/frappe/list/list_view.js
@@ -1008,13 +1008,6 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 			standard: true
 		});
 
-		// add to desktop
-		items.push({
-			label: __('Add to Desktop'),
-			action: () => frappe.add_to_desktop(doctype, doctype),
-			standard: true
-		});
-
 		if (frappe.user.has_role('System Manager') && frappe.boot.developer_mode === 1) {
 			// edit doctype
 			items.push({
diff --git a/frappe/public/js/frappe/views/reports/query_report.js b/frappe/public/js/frappe/views/reports/query_report.js
index 2bad83b828..fee56ac750 100644
--- a/frappe/public/js/frappe/views/reports/query_report.js
+++ b/frappe/public/js/frappe/views/reports/query_report.js
@@ -961,12 +961,7 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
 				}),
 				condition: () => frappe.model.can_set_user_permissions('Report'),
 				standard: true
-			},
-			{
-				label: __('Add to Desktop'),
-				action: () => frappe.add_to_desktop(this.report_name, null, this.report_name),
-				standard: true
-			},
+			}
 		];
 	}
 
diff --git a/frappe/public/js/frappe/views/reports/report_view.js b/frappe/public/js/frappe/views/reports/report_view.js
index 921bfe07a1..d4c136379b 100644
--- a/frappe/public/js/frappe/views/reports/report_view.js
+++ b/frappe/public/js/frappe/views/reports/report_view.js
@@ -1186,18 +1186,7 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
 					frappe.set_route('List', 'User Permission', args);
 				}
 			});
-		}
-
-		// add to desktop
-		items.push({
-			label: __('Add to Desktop'),
-			action: () => {
-				frappe.add_to_desktop(
-					this.report_name || __('{0} Report', [this.doctype]),
-					this.doctype, this.report_name
-				);
-			}
-		});
+		};
 
 		return items.map(i => Object.assign(i, { standard: true }));
 	}
diff --git a/frappe/public/js/frappe/views/reports/reportview.js b/frappe/public/js/frappe/views/reports/reportview.js
index f10e0922af..0400cf995e 100644
--- a/frappe/public/js/frappe/views/reports/reportview.js
+++ b/frappe/public/js/frappe/views/reports/reportview.js
@@ -107,11 +107,6 @@ frappe.views.ReportView = frappe.ui.BaseList.extend({
 		this.set_tag_and_status_filter();
 		this.setup_listview_settings();
 
-		// add to desktop
-		this.page.add_menu_item(__("Add to Desktop"), function() {
-			frappe.add_to_desktop(me.docname || __('{0} Report', [me.doctype]), me.doctype, me.docname);
-		}, true);
-
 	},
 
 	make_new_and_refresh: function() {
diff --git a/frappe/public/js/frappe/views/treeview.js b/frappe/public/js/frappe/views/treeview.js
index dda728cff5..cc83a1c193 100644
--- a/frappe/public/js/frappe/views/treeview.js
+++ b/frappe/public/js/frappe/views/treeview.js
@@ -373,14 +373,6 @@ frappe.views.TreeView = Class.extend({
 				me.page.add_menu_item(menu_item["label"], menu_item["action"]);
 			}
 		});
-
-		// last menu item
-		me.page.add_menu_item(__('Add to Desktop'), () => {
-			const label = me.doctype === 'Account' ?
-				__('Chart of Accounts') :
-				__(me.doctype);
-			frappe.add_to_desktop(label, me.doctype);
-		});
 	}
 });