vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #28916 from ankush/perf/skip_defaults

Browse source 
perf: use system settings instead of defaults
This commit is contained in:
Ankush Menat 2024-12-26 12:06:37 +05:30 • committed by GitHub
commit 304dae9136
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/commands/utils.py
View file

@ -582,7 +582,7 @@ Run the following in your first cell to connect notebook to frappe
import frappe
frappe.init('{site}', sites_path='{sites_path}')
frappe.connect()
frappe.local.lang = frappe.db.get_default('lang')
frappe.local.lang = frappe.get_system_settings('language')
frappe.db.connect()
```
"""
@ -623,7 +623,7 @@ def console(context: CliCtxObj, autoreload=False):
site = get_site(context)
frappe.init(site)
frappe.connect()
frappe.local.lang = frappe.db.get_default("lang")
frappe.local.lang = frappe.get_system_settings("language")
from atexit import register

2
frappe/sessions.py
View file

@ -451,7 +451,7 @@ def get_expired_threshold():
def get_expiry_period():
exp_sec = frappe.defaults.get_global_default("session_expiry") or "240:00:00"
exp_sec = frappe.get_system_settings("session_expiry") or "240:00:00"
# incase seconds is missing
if len(exp_sec.split(":")) == 2:

4
frappe/translate.py
View file

@ -77,7 +77,7 @@ def get_language(lang_list: list | None = None) -> str:
return parent_language
# fallback to language set in System Settings or "en"
return frappe.db.get_default("lang") or "en"
return frappe.get_system_settings("language") or "en"
@functools.lru_cache
@ -100,7 +100,7 @@ def get_user_lang(user: str | None = None) -> str:
# User.language => Session Defaults => frappe.local.lang => 'en'
return (
frappe.get_cached_value("User", user, "language")
or frappe.db.get_default("lang")
or frappe.get_system_settings("language")
or frappe.local.lang
or "en"
)