From 30dda5287c9bce3bff66eafa7877154d26e495b8 Mon Sep 17 00:00:00 2001 From: David Arnold Date: Wed, 16 Oct 2024 16:18:36 +0200 Subject: [PATCH] test: remove toleration for test record creation failure (#28143) this ensures test record creation conforms with the spec or fails sharply --- frappe/tests/utils/generators.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/frappe/tests/utils/generators.py b/frappe/tests/utils/generators.py index f9b1655a52..d65aa2af8a 100644 --- a/frappe/tests/utils/generators.py +++ b/frappe/tests/utils/generators.py @@ -323,17 +323,11 @@ def _try_create(record, reset=False, commit=False) -> tuple["Document", bool]: d.docstatus = 0 - tolerated_errors = (frappe.NameError, *(d.flags.ignore_these_exceptions_in_test or [])) - try: - d.run_method("before_test_insert") - d.insert(ignore_if_duplicate=True) + d.run_method("before_test_insert") + d.insert(ignore_if_duplicate=True) - if docstatus == 1: - d.submit() - - except tolerated_errors as e: - logger.warning(f"Error during test record creation for {d.name} ({d.doctype}): {e!s}") - revert_naming(d) + if docstatus == 1: + d.submit() if commit: frappe.db.commit()