From 324c3e24c4085d13650aa2075e2a0e02166fd433 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Mon, 2 Jan 2023 10:20:16 +0530
Subject: [PATCH] fix: replace all spaces with _ to generate fieldname

---
 frappe/public/js/form_builder/utils.js                      | 4 ++--
 frappe/website/doctype/web_form/templates/web_form_row.html | 4 ++++
 frappe/website/doctype/web_form/web_form.json               | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
 create mode 100644 frappe/website/doctype/web_form/templates/web_form_row.html

diff --git a/frappe/public/js/form_builder/utils.js b/frappe/public/js/form_builder/utils.js
index d149a48c16..4c2887e4e7 100644
--- a/frappe/public/js/form_builder/utils.js
+++ b/frappe/public/js/form_builder/utils.js
@@ -279,7 +279,7 @@ export function scrub_field_names(fields) {
 		if (d.fieldtype) {
 			if (!d.fieldname) {
 				if (d.label) {
-					d.fieldname = d.label.trim().toLowerCase().replace(" ", "_");
+					d.fieldname = d.label.trim().toLowerCase().replaceAll(" ", "_");
 					if (d.fieldname.endsWith("?")) {
 						d.fieldname = d.fieldname.slice(0, -1);
 					}
@@ -295,7 +295,7 @@ export function scrub_field_names(fields) {
 					}
 				} else {
 					d.fieldname =
-						d.fieldtype.toLowerCase().replace(" ", "_") +
+						d.fieldtype.toLowerCase().replaceAll(" ", "_") +
 						"_" +
 						frappe.utils.get_random(4);
 				}
diff --git a/frappe/website/doctype/web_form/templates/web_form_row.html b/frappe/website/doctype/web_form/templates/web_form_row.html
new file mode 100644
index 0000000000..d7014b453a
--- /dev/null
+++ b/frappe/website/doctype/web_form/templates/web_form_row.html
@@ -0,0 +1,4 @@
+<div>
+	<a href="{{ doc.route }}">{{ doc.title or doc.name }}</a>
+</div>
+<!-- this is a sample default list template -->
diff --git a/frappe/website/doctype/web_form/web_form.json b/frappe/website/doctype/web_form/web_form.json
index 0c2e416696..21e501481b 100644
--- a/frappe/website/doctype/web_form/web_form.json
+++ b/frappe/website/doctype/web_form/web_form.json
@@ -364,7 +364,7 @@
  "icon": "icon-edit",
  "is_published_field": "published",
  "links": [],
- "modified": "2022-12-15 17:14:44.939645",
+ "modified": "2023-01-02 10:19:15.680960",
  "modified_by": "Administrator",
  "module": "Website",
  "name": "Web Form",