diff --git a/frappe/desk/doctype/workspace/workspace.js b/frappe/desk/doctype/workspace/workspace.js index c08d73dfcc..b5f298c477 100644 --- a/frappe/desk/doctype/workspace/workspace.js +++ b/frappe/desk/doctype/workspace/workspace.js @@ -41,6 +41,10 @@ frappe.ui.form.on("Workspace", { } } + if (frappe.boot.developer_mode) { + frm.set_df_property("module", "read_only", 0); + } + frm.layout.show_message(message); }, diff --git a/frappe/desk/doctype/workspace/workspace.json b/frappe/desk/doctype/workspace/workspace.json index 4b89f1582f..58a1f718fd 100644 --- a/frappe/desk/doctype/workspace/workspace.json +++ b/frappe/desk/doctype/workspace/workspace.json @@ -71,7 +71,8 @@ "in_list_view": 1, "in_standard_filter": 1, "label": "Module", - "options": "Module Def" + "options": "Module Def", + "read_only": 1 }, { "fieldname": "column_break_3", @@ -177,7 +178,7 @@ ], "in_create": 1, "links": [], - "modified": "2023-01-05 16:22:42.593601", + "modified": "2023-01-07 17:02:48.278025", "modified_by": "Administrator", "module": "Desk", "name": "Workspace", diff --git a/frappe/public/js/frappe/views/workspace/workspace.js b/frappe/public/js/frappe/views/workspace/workspace.js index b287a96906..cbcea38f38 100644 --- a/frappe/public/js/frappe/views/workspace/workspace.js +++ b/frappe/public/js/frappe/views/workspace/workspace.js @@ -448,7 +448,7 @@ frappe.views.Workspace = class Workspace { frappe.show_alert({ message: __("Customizations Discarded"), indicator: "info" }); }); - if (page.name && frappe.perm.has_perm("Workspace", 0, "read")) { + if (page.name && this.has_access) { this.page.add_inner_button(__("Settings"), () => { frappe.set_route(`workspace/${page.name}`); }); @@ -720,13 +720,16 @@ frappe.views.Workspace = class Workspace { icon: frappe.utils.icon("duplicate", "sm"), action: () => this.duplicate_page(item), }, - { + ]; + + if (this.is_item_deletable(item)) { + this.dropdown_list.push({ label: __("Delete"), title: __("Delete Workspace"), icon: frappe.utils.icon("delete-active", "sm"), action: () => this.delete_page(item), - }, - ]; + }); + } let $button = $(`