From 6f8fd738c4ad37f2fc551296552449f69f54c5e2 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Sat, 7 Jan 2023 17:18:58 +0530
Subject: [PATCH 1/3] fix: do not show delete button for standard workspace if
 developer_mode is not on

---
 .../js/frappe/views/workspace/workspace.js    | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/frappe/public/js/frappe/views/workspace/workspace.js b/frappe/public/js/frappe/views/workspace/workspace.js
index 96b3f4e15a..1ccb8ff72b 100644
--- a/frappe/public/js/frappe/views/workspace/workspace.js
+++ b/frappe/public/js/frappe/views/workspace/workspace.js
@@ -719,13 +719,16 @@ frappe.views.Workspace = class Workspace {
 				icon: frappe.utils.icon("duplicate", "sm"),
 				action: () => this.duplicate_page(item),
 			},
-			{
+		];
+
+		if (this.is_item_deletable(item)) {
+			this.dropdown_list.push({
 				label: __("Delete"),
 				title: __("Delete Workspace"),
 				icon: frappe.utils.icon("delete-active", "sm"),
 				action: () => this.delete_page(item),
-			},
-		];
+			});
+		}
 
 		let $button = $(`
 			<div class="btn btn-secondary btn-xs setting-btn dropdown-btn" title="${__("Setting")}">
@@ -767,6 +770,19 @@ frappe.views.Workspace = class Workspace {
 		});
 	}
 
+	is_item_deletable(item) {
+		// if item is private
+		// if item is public but doesn't have module set
+		// if item is public and has module set but developer mode is on
+		// then item is deletable
+		if (
+			!item.public ||
+			(item.public && (!item.module || (item.module && frappe.boot.developer_mode)))
+		)
+			return true;
+		return false;
+	}
+
 	delete_page(page) {
 		frappe.confirm(
 			__("Are you sure you want to delete page {0}?", [page.title.bold()]),

From 580c9d657136ea9c439782f7cfc7677d19075c45 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Sat, 7 Jan 2023 17:19:38 +0530
Subject: [PATCH 2/3] fix: do not allow to change module field if
 developer_mode is not set

---
 frappe/desk/doctype/workspace/workspace.js   | 4 ++++
 frappe/desk/doctype/workspace/workspace.json | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/frappe/desk/doctype/workspace/workspace.js b/frappe/desk/doctype/workspace/workspace.js
index c08d73dfcc..b5f298c477 100644
--- a/frappe/desk/doctype/workspace/workspace.js
+++ b/frappe/desk/doctype/workspace/workspace.js
@@ -41,6 +41,10 @@ frappe.ui.form.on("Workspace", {
 			}
 		}
 
+		if (frappe.boot.developer_mode) {
+			frm.set_df_property("module", "read_only", 0);
+		}
+
 		frm.layout.show_message(message);
 	},
 
diff --git a/frappe/desk/doctype/workspace/workspace.json b/frappe/desk/doctype/workspace/workspace.json
index 529fc8bf8b..83437cd142 100644
--- a/frappe/desk/doctype/workspace/workspace.json
+++ b/frappe/desk/doctype/workspace/workspace.json
@@ -71,7 +71,8 @@
    "in_list_view": 1,
    "in_standard_filter": 1,
    "label": "Module",
-   "options": "Module Def"
+   "options": "Module Def",
+   "read_only": 1
   },
   {
    "fieldname": "column_break_3",
@@ -177,7 +178,7 @@
  ],
  "in_create": 1,
  "links": [],
- "modified": "2022-08-16 18:01:42.632238",
+ "modified": "2023-01-07 17:02:48.278025",
  "modified_by": "Administrator",
  "module": "Desk",
  "name": "Workspace",

From 6f1e3e1a91e39db33209f6a86050dcee0d52a1c1 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Sat, 7 Jan 2023 19:01:41 +0530
Subject: [PATCH 3/3] fix: show settings button only to workspace manager

---
 frappe/public/js/frappe/views/workspace/workspace.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/views/workspace/workspace.js b/frappe/public/js/frappe/views/workspace/workspace.js
index 5f20356463..cbcea38f38 100644
--- a/frappe/public/js/frappe/views/workspace/workspace.js
+++ b/frappe/public/js/frappe/views/workspace/workspace.js
@@ -448,7 +448,7 @@ frappe.views.Workspace = class Workspace {
 			frappe.show_alert({ message: __("Customizations Discarded"), indicator: "info" });
 		});
 
-		if (page.name && frappe.perm.has_perm("Workspace", 0, "read")) {
+		if (page.name && this.has_access) {
 			this.page.add_inner_button(__("Settings"), () => {
 				frappe.set_route(`workspace/${page.name}`);
 			});