From 3354fe9db470ee101c6f2240fd22f7ccc4d5d1e5 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 18 Jul 2024 11:36:15 +0530 Subject: [PATCH] fix(newsletter): prevent `UnboundLocalError` when `doc` is not associated with a value Signed-off-by: Akhil Narang --- frappe/email/doctype/newsletter/newsletter.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/email/doctype/newsletter/newsletter.py b/frappe/email/doctype/newsletter/newsletter.py index 45d5c35d99..5b39a00d7e 100644 --- a/frappe/email/doctype/newsletter/newsletter.py +++ b/frappe/email/doctype/newsletter/newsletter.py @@ -439,7 +439,11 @@ def newsletter_email_read(recipient_email=None, reference_doctype=None, referenc ).run() except Exception: - doc.log_error(f"Unable to mark as viewed for {recipient_email}") + frappe.log_error( + title=f"Unable to mark as viewed for {recipient_email}", + reference_doctype="Newsletter", + reference_name=reference_name, + ) finally: frappe.response.update(frappe.utils.get_imaginary_pixel_response())