From 348202b6fcdcb69dec4fdbdfcb5ffe1fa4c43093 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 14 Apr 2025 18:53:13 +0530 Subject: [PATCH] fix(UX): block inserting more than 5000 items in table (#32127) The "upload" feature allows adding arbitrary number of rows and browsers usually can't handle >1000 well in current grid (+ backend doesn't support this either) --- frappe/public/js/frappe/form/grid.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index 132827b782..10f2c27adc 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -1112,6 +1112,9 @@ export default class Grid { var data = frappe.utils.csv_to_array( frappe.utils.get_decoded_string(file.dataurl) ); + if (cint(data.length) - 7 > 5000) { + frappe.throw(__("Cannot import table with more than 5000 rows.")); + } // row #2 contains fieldnames; var fieldnames = data[2]; me.frm.clear_table(me.df.fieldname);