vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #31750 from sagarvora/perf-as_dict-

Browse source 
perf: reduce repeated attribute access in `as_dict`
This commit is contained in:
Sagar Vora 2025-03-17 09:26:01 +05:30 • committed by GitHub
commit 36b2d47c14
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/model/base_document.py
View file

@ -409,6 +409,7 @@ class BaseDocument:
) -> _dict:
d = _dict()
field_values = self.__dict__
field_map = self.meta._fields
for fieldname in self.meta.get_valid_fields():
value = field_values.get(fieldname)
@ -418,7 +419,7 @@ class BaseDocument:
d[fieldname] = None
continue
df = self.meta.get_field(fieldname)
df = field_map.get(fieldname)
is_virtual_field = getattr(df, "is_virtual", False)
if df:
@ -438,22 +439,23 @@ class BaseDocument:
eval_locals={"doc": self},
)
if isinstance(value, list) and df.fieldtype not in table_fields:
fieldtype = df.fieldtype
if isinstance(value, list) and fieldtype not in table_fields:
frappe.throw(_("Value for {0} cannot be a list").format(_(df.label, context=df.parent)))
if df.fieldtype == "Check":
if fieldtype == "Check":
value = 1 if cint(value) else 0
elif df.fieldtype == "Int" and not isinstance(value, int):
elif fieldtype == "Int" and not isinstance(value, int):
value = cint(value)
elif df.fieldtype == "JSON" and isinstance(value, dict):
elif fieldtype == "JSON" and isinstance(value, dict):
value = json.dumps(value, separators=(",", ":"))
elif df.fieldtype in float_like_fields and not isinstance(value, float):
elif fieldtype in float_like_fields and not isinstance(value, float):
value = flt(value)
elif (df.fieldtype in datetime_fields and value == "") or (
elif (fieldtype in datetime_fields and value == "") or (
getattr(df, "unique", False) and cstr(value).strip() == ""
):
value = None