From f1fdb5003426af9a05865ac35cdeb060a498c063 Mon Sep 17 00:00:00 2001 From: UmakanthKaspa Date: Wed, 21 May 2025 12:10:08 +0000 Subject: [PATCH 1/2] feat: add 'show full number' option to number card --- frappe/desk/doctype/number_card/number_card.json | 13 +++++++++++-- frappe/desk/doctype/number_card/number_card.py | 1 + .../public/js/frappe/widgets/number_card_widget.js | 13 +++++++++++-- 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/frappe/desk/doctype/number_card/number_card.json b/frappe/desk/doctype/number_card/number_card.json index 08d21ec4a4..b52f139f87 100644 --- a/frappe/desk/doctype/number_card/number_card.json +++ b/frappe/desk/doctype/number_card/number_card.json @@ -21,6 +21,7 @@ "report_function", "is_public", "currency", + "show_full_number", "custom_configuration_section", "filters_config", "stats_section", @@ -207,10 +208,17 @@ "fieldtype": "Link", "label": "Currency", "options": "Currency" + }, + { + "default": "0", + "description": "Check to show full numeric value (e.g. 1,234,567 instead of 1.2M)", + "fieldname": "show_full_number", + "fieldtype": "Check", + "label": "Show Full Number" } ], "links": [], - "modified": "2025-01-28 18:22:27.268239", + "modified": "2025-05-21 17:33:04.908518", "modified_by": "Administrator", "module": "Desk", "name": "Number Card", @@ -250,10 +258,11 @@ "share": 1 } ], + "row_format": "Dynamic", "search_fields": "label, document_type", "sort_field": "creation", "sort_order": "DESC", "states": [], "title_field": "label", "track_changes": 1 -} \ No newline at end of file +} diff --git a/frappe/desk/doctype/number_card/number_card.py b/frappe/desk/doctype/number_card/number_card.py index 9f78e1a69f..9ecfd1669f 100644 --- a/frappe/desk/doctype/number_card/number_card.py +++ b/frappe/desk/doctype/number_card/number_card.py @@ -39,6 +39,7 @@ class NumberCard(Document): report_field: DF.Literal[None] report_function: DF.Literal["Sum", "Average", "Minimum", "Maximum"] report_name: DF.Link | None + show_full_number: DF.Check show_percentage_stats: DF.Check stats_time_interval: DF.Literal["Daily", "Weekly", "Monthly", "Yearly"] type: DF.Literal["Document Type", "Report", "Custom"] diff --git a/frappe/public/js/frappe/widgets/number_card_widget.js b/frappe/public/js/frappe/widgets/number_card_widget.js index c7c38da91b..042e437d26 100644 --- a/frappe/public/js/frappe/widgets/number_card_widget.js +++ b/frappe/public/js/frappe/widgets/number_card_widget.js @@ -218,8 +218,17 @@ export default class NumberCardWidget extends Widget { set_formatted_number(df, doc) { const default_country = frappe.sys_defaults.country; - const shortened_number = frappe.utils.shorten_number(this.number, default_country, 5); - let number_parts = shortened_number.split(" "); + + let number_parts; + + // Use full number if the checkbox is enabled + if (this.card_doc.show_full_number) { + number_parts = [this.number.toString(), ""]; + } else { + const shortened_number = frappe.utils.shorten_number(this.number, default_country, 5); + number_parts = shortened_number.split(" "); + } + // done to add multicurrency support in number card if (this.card_doc.currency) { this.formatted_number = From c16bdcd80c79e92e205741ded799658582c42d81 Mon Sep 17 00:00:00 2001 From: UmakanthKaspa Date: Thu, 22 May 2025 10:46:28 +0530 Subject: [PATCH 2/2] feat(number-card): update description for 'Show Full Number' checkbox Co-authored-by: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com> --- frappe/desk/doctype/number_card/number_card.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/desk/doctype/number_card/number_card.json b/frappe/desk/doctype/number_card/number_card.json index b52f139f87..1e0eee5c37 100644 --- a/frappe/desk/doctype/number_card/number_card.json +++ b/frappe/desk/doctype/number_card/number_card.json @@ -211,7 +211,7 @@ }, { "default": "0", - "description": "Check to show full numeric value (e.g. 1,234,567 instead of 1.2M)", + "description": "Check to display the full numeric value (e.g., 1,234,567 instead of 1.2M).", "fieldname": "show_full_number", "fieldtype": "Check", "label": "Show Full Number"