vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: added is_last_slide method in slides

Browse source
This commit is contained in:
Rucha Mahabal 2019-12-04 16:21:18 +05:30
parent d9bbd10382
commit 36dd074dcc
3 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/desk/doctype/onboarding_slide/onboarding_slide.js
View file

@ -3,8 +3,8 @@
frappe.ui.form.on('Onboarding Slide', {
refresh: function(frm) {
frm.toggle_reqd('ref_doctype', frm.doc.slide_type!='Information');
frm.toggle_reqd('slide_module', frm.doc.slide_type=='Information');
frm.toggle_reqd('ref_doctype', (frm.doc.slide_type=='Create' || frm.doc.slide_type=='Settings'));
frm.toggle_reqd('slide_module', (frm.doc.slide_type=='Information' || frm.doc.slide_type=='Continue'));
},
ref_doctype: function(frm) {

6
frappe/public/js/frappe/ui/onboarding_dialog.js
View file

@ -26,7 +26,7 @@ frappe.setup.OnboardingSlide = class OnboardingSlide extends frappe.ui.Slide {
(this.id === 0) ?
this.$next_btn.text(__('Let\'s Start')) : this.$next_btn.text(__('Next'));
//last slide
if (this.id === this.parent[0].children.length-1) {
if (this.is_last_slide()) {
this.$complete_btn.removeClass('hide').addClass('action primary');
this.$next_btn.removeClass('action primary');
this.$action_button = this.$complete_btn;
@ -48,7 +48,7 @@ frappe.setup.OnboardingSlide = class OnboardingSlide extends frappe.ui.Slide {
slide_type: me.slide_type
},
callback: function() {
if (me.id === me.parent[0].children.length-1) {
if (me.is_last_slide()) {
me.reset_is_first_startup();
$('.onboarding-dialog').modal('toggle');
frappe.msgprint({
@ -86,7 +86,7 @@ frappe.setup.OnboardingSlide = class OnboardingSlide extends frappe.ui.Slide {
}
setup_action_button() {
if (this.slide_type === 'Create' || this.slide_type == 'Settings' || this.id === this.parent[0].children.length-1) {
if (this.slide_type === 'Create' || this.slide_type == 'Settings' || this.is_last_slide()) {
this.$action_button.addClass('primary');
} else {
this.$action_button.removeClass('primary');

7
frappe/public/js/frappe/ui/slides.js
View file

@ -182,6 +182,13 @@ frappe.ui.Slide = class Slide {
});
}
is_last_slide() {
if (this.id === this.parent[0].children.length-1) {
return true;
}
return false;
}
before_show() { }
show_slide() {