From 3759e5bbcd32dfe830b36ce8a5b76a7059f363e1 Mon Sep 17 00:00:00 2001 From: Aradhya Date: Sat, 12 Nov 2022 19:41:21 +0530 Subject: [PATCH] refactor: lint fix: removed time.sleep --- frappe/core/doctype/submission_queue/submission_queue.py | 4 ---- frappe/desk/form/save.py | 6 +----- frappe/tests/test_document_locks.py | 7 +++---- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/frappe/core/doctype/submission_queue/submission_queue.py b/frappe/core/doctype/submission_queue/submission_queue.py index 39f36fa356..2bb4200a87 100644 --- a/frappe/core/doctype/submission_queue/submission_queue.py +++ b/frappe/core/doctype/submission_queue/submission_queue.py @@ -70,10 +70,6 @@ class SubmissionQueue(Document): def background_submission(self, to_be_queued_doc: Document, action_for_queuing: str): # Set the job id for that submission doctype self.update_job_id(get_current_job().id) - import time - - time.sleep(10) - _action = action_for_queuing.lower() if _action == "update": _action = "submit" diff --git a/frappe/desk/form/save.py b/frappe/desk/form/save.py index 8ea5b120e6..f43031c899 100644 --- a/frappe/desk/form/save.py +++ b/frappe/desk/form/save.py @@ -19,11 +19,7 @@ def savedocs(doc, action): # action doc.docstatus = {"Save": 0, "Submit": 1, "Update": 1, "Cancel": 2}[action] if doc.docstatus == 1: - if ( - action == "Submit" - and doc.meta.queue_in_background - and not is_scheduler_inactive() - ): + if action == "Submit" and doc.meta.queue_in_background and not is_scheduler_inactive(): queue_submission(doc, action) return doc.submit() diff --git a/frappe/tests/test_document_locks.py b/frappe/tests/test_document_locks.py index 2ba606685e..5d19f75050 100644 --- a/frappe/tests/test_document_locks.py +++ b/frappe/tests/test_document_locks.py @@ -27,13 +27,12 @@ class TestDocumentLocks(FrappeTestCase): # Checking for persistant locks across all instances. doc = frappe.get_doc("ToDo", todo.name) - self.assertEquals(doc.is_locked, True) + self.assertEqual(doc.is_locked, True) with self.assertRaises(frappe.DocumentLockedError): doc.description = "Random" doc.save() doc.unlock() - self.assertEquals(doc.is_locked, False) - self.assertEquals(todo.is_locked, False) - + self.assertEqual(doc.is_locked, False) + self.assertEqual(todo.is_locked, False)